linux-kernel - Re: [PATCH 11/12] PCMCIA: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191208205713.GG240074@light.dominikbrodowski.net>
Date:   Sun, 8 Dec 2019 21:57:13 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Simon Geis <simon.geis@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Colin Ian King <colin.king@...onical.com>,
        Adam Zerella <adam.zerella@...il.com>,
        linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de,
        Lukas Panzer <lukas.panzer@....de>
Subject: Re: [PATCH 11/12] PCMCIA: use dev_dbg instead of enter/leave

On Sun, Dec 08, 2019 at 05:09:46PM +0100, Simon Geis wrote:
> Using dev_dbg() instead of the enter()/leave()
> macro. This allows the usage of format strings.
> Remove the now unused macro definition in i82092aa.h.

Could you re-use enter()/leave() (maybe with a new parameter
to pass the struct pci_dev) here instead? That may save a few lines, instead
of prolonging the file?

Thanks,
	Dominik