linux-kernel - Re: [PATCH] tools lib: Disable redundant-delcs error for strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191208221358.GA30636@altlinux.org>
Date:   Mon, 9 Dec 2019 01:13:58 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Vitaly Chikunov <vt@...linux.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Vineet Gupta <Vineet.Gupta1@...opsys.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] tools lib: Disable redundant-delcs error for strlcpy

On Mon, Dec 09, 2019 at 12:46:07AM +0300, Vitaly Chikunov wrote:
> Disable `redundant-decls' error for strlcpy declaration and solve build
> error allowing users to compile vanilla kernels.
> 
> When glibc have strlcpy (such as in ALT linux since 2004) objtool and
> perf build fails with something like:
> 
>   In file included from exec-cmd.c:3:
>   tools/include/linux/string.h:20:15: error: redundant redeclaration of ‘strlcpy’ [-Werror=redundant-decls]
>      20 | extern size_t strlcpy(char *dest, const char *src, size_t size);
> 	|               ^~~~~~~
> 
> It's very hard to produce a perfect fix for that since it is a header
> file indirectly pulled from many sources from different Makefile builds.
> 
> Fixes: ce99091 ("perf tools: Move strlcpy() from perf to tools/lib/string.c")
> Fixes: 0215d59 ("tools lib: Reinstate strlcpy() header guard with __UCLIBC__")
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>
> Cc: Dmitry V. Levin <ldv@...linux.org>
> Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> Cc: Vineet Gupta <Vineet.Gupta1@...opsys.com>
> Cc: stable@...r.kernel.org

Apparently, this patch also addresses
https://bugzilla.kernel.org/show_bug.cgi?id=118481


-- 
ldv

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)