linux-kernel - Re: [PATCH] ALSA: echoaudio: simplify get_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h36dvcies.wl-tiwai@suse.de>
Date:   Sun, 08 Dec 2019 09:48:11 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Olof Johansson <olof@...om.net>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: echoaudio: simplify get_audio_levels

On Sat, 07 Dec 2019 23:49:53 +0100,
Olof Johansson wrote:
> 
> The loop optimizer seems to go astray here, and produces some warnings
> that don't seem valid.
> 
> Still, the code can be simplified -- just clear the whole array at the
> beginning, and fill in whatever values are valid on the platform.
> 
> Warnings before this change (GCC 8.2.0 ARM allmodconfig):
> 
> In file included from ../sound/pci/echoaudio/gina24.c:115:
> ../sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vumeters_get':
> ../sound/pci/echoaudio/echoaudio_dsp.c:647:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
> In file included from ../sound/pci/echoaudio/layla24.c:112:
> ../sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vumeters_get':
> ../sound/pci/echoaudio/echoaudio_dsp.c:658:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
> ../sound/pci/echoaudio/echoaudio_dsp.c:647:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
> 
> Signed-off-by: Olof Johansson <olof@...om.net>

Applied now, thanks.


Takashi