linux-kernel - Re: [PATCH v6 5/5] scsi: ufs: Do not free irq in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1575808849.12066.3.camel@mtkswgap22>
Date:   Sun, 8 Dec 2019 20:40:49 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Can Guo <cang@...eaurora.org>
CC:     <asutoshd@...eaurora.org>, <nguyenb@...eaurora.org>,
        <rnayak@...eaurora.org>, <linux-scsi@...r.kernel.org>,
        <kernel-team@...roid.com>, <saravanak@...gle.com>,
        <salyzyn@...gle.com>, Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Bean Huo <beanhuo@...ron.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 5/5] scsi: ufs: Do not free irq in suspend

Hi Can,

On Thu, 2019-12-05 at 02:14 +0000, Can Guo wrote:
> Since ufshcd irq resource is allocated with the device resource management
> aware IRQ request implementation, we don't really need to free up irq
> during suspend, disabling it during suspend and reenabling it during resume
> should be good enough.

This is good in consideration of performance: enable_irq/disable_irq
performance is much better than request_irq/free_irq.

Reviewed-by: Stanley Chu <stanley.chu@...iatek.com>