linux-kernel - Re: [PATCH v0] irqchip/gic-v3: Avoid check of lpi configuration for non existent cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201912100457.zVTc2cLX%lkp@intel.com>
Date:   Tue, 10 Dec 2019 04:55:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Gaurav Kohli <gkohli@...eaurora.org>
Cc:     kbuild-all@...ts.01.org, tglx@...utronix.de, maz@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Gaurav Kohli <gkohli@...eaurora.org>
Subject: Re: [PATCH v0] irqchip/gic-v3: Avoid check of lpi configuration for
 non existent cpu

Hi Gaurav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on v5.5-rc1 next-20191209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gaurav-Kohli/irqchip-gic-v3-Avoid-check-of-lpi-configuration-for-non-existent-cpu/20191207-092729
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 407e62f52aadd8124dcba407f18a03aedce9b86a
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers//irqchip/irq-gic-v3.c: In function 'gic_iterate_rdists':
>> drivers//irqchip/irq-gic-v3.c:801:30: error: 'INVALID_HWID' undeclared (first use in this function); did you mean 'INVALID_UID'?
         cpu_logical_map(cpu) != INVALID_HWID);
                                 ^~~~~~~~~~~~
                                 INVALID_UID
   drivers//irqchip/irq-gic-v3.c:801:30: note: each undeclared identifier is reported only once for each function it appears in

vim +801 drivers//irqchip/irq-gic-v3.c

   764	
   765	static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *))
   766	{
   767		int ret = -ENODEV;
   768		int i;
   769		int cpu = 0;
   770	
   771		for (i = 0; i < gic_data.nr_redist_regions; i++) {
   772			void __iomem *ptr = gic_data.redist_regions[i].redist_base;
   773			u64 typer;
   774			u32 reg;
   775	
   776			reg = readl_relaxed(ptr + GICR_PIDR2) & GIC_PIDR2_ARCH_MASK;
   777			if (reg != GIC_PIDR2_ARCH_GICv3 &&
   778			    reg != GIC_PIDR2_ARCH_GICv4) { /* We're in trouble... */
   779				pr_warn("No redistributor present @%p\n", ptr);
   780				break;
   781			}
   782	
   783			do {
   784				cpu++;
   785				typer = gic_read_typer(ptr + GICR_TYPER);
   786				ret = fn(gic_data.redist_regions + i, ptr);
   787				if (!ret)
   788					return 0;
   789	
   790				if (gic_data.redist_regions[i].single_redist)
   791					break;
   792	
   793				if (gic_data.redist_stride) {
   794					ptr += gic_data.redist_stride;
   795				} else {
   796					ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
   797					if (typer & GICR_TYPER_VLPIS)
   798						ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
   799				}
   800			} while (!(typer & GICR_TYPER_LAST) &&
 > 801						cpu_logical_map(cpu) != INVALID_HWID);
   802		}
   803	
   804		return ret ? -ENODEV : 0;
   805	}
   806	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (72070 bytes)