linux-kernel - Re: [PATCH V4] scsi: avoid potential deadlock in iscsi_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1o8whqem3.fsf@oracle.com>
Date:   Mon, 09 Dec 2019 18:11:00 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "wubo \(T\)" <wubo40@...wei.com>
Cc:     Lee Duncan <LDuncan@...e.com>,
        "cleech\@redhat.com" <cleech@...hat.com>,
        "jejb\@linux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen\@oracle.com" <martin.petersen@...cle.com>,
        "open-iscsi\@googlegroups.com" <open-iscsi@...glegroups.com>,
        "linux-scsi\@vger.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Ulrich Windl <Ulrich.Windl@...uni-regensburg.de>,
        Mingfangsen <mingfangsen@...wei.com>,
        "liuzhiqiang \(I\)" <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH V4] scsi: avoid potential deadlock in iscsi_if_rx func


wubo,

> In iscsi_if_rx func, after receiving one request through
> iscsi_if_recv_msg func, iscsi_if_send_reply will be called to try to
> reply the request in do-loop.  If the return of iscsi_if_send_reply
> func return -EAGAIN all the time, one deadlock will occur.
>
> For example, a client only send msg without calling recvmsg func, then
> it will result in the watchdog soft lockup.  The details are given as
> follows,

> Signed-off-by: Bo Wu <wubo40@...wei.com>
> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
> Reviewed-by: Lee Duncan <LDuncan@...e.com>

I haven't seen a Reviewed-by: from Lee on this patch.

-- 
Martin K. Petersen	Oracle Linux Engineering