linux-kernel - Re: [PATCH] arm64: dts: ls1028a: fix reboot node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 09 Dec 2019 10:02:02 +0100
From:   Michael Walle <michael@...le.cc>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix reboot node

Am 2019-12-09 04:47, schrieb Shawn Guo:
> On Sat, Nov 23, 2019 at 01:07:09AM +0100, Michael Walle wrote:
>> The reboot register isn't located inside the DCFG controller, but in 
>> its
>> own RST controller. Fix it.
>> 
>> Signed-off-by: Michael Walle <michael@...le.cc>
>> ---
>>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 72b9a75976a1..dc75534a4754 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -102,7 +102,7 @@
>> 
>>  	reboot {
>>  		compatible ="syscon-reboot";
>> -		regmap = <&dcfg>;
>> +		regmap = <&rst>;
>>  		offset = <0xb0>;
>>  		mask = <0x02>;
>>  	};
>> @@ -161,6 +161,12 @@
>>  			big-endian;
>>  		};
>> 
>> +		rst: syscon@...0000 {
>> +			compatible = "fsl,ls1028a-rst", "syscon";
> 
> Compatible "fsl,ls1028a-rst" seems undocumented?

it is the same with fsl,ls1028a-scfg and fsl,ls1028a-dcfg. So maybe I 
should just drop the "fsl,ls1028a-rst". What do you think?

-michael

> 
> Shawn
> 
>> +			reg = <0x0 0x1e60000 0x0 0x10000>;
>> +			little-endian;
>> +		};
>> +
>>  		scfg: syscon@...0000 {
>>  			compatible = "fsl,ls1028a-scfg", "syscon";
>>  			reg = <0x0 0x1fc0000 0x0 0x10000>;
>> --
>> 2.20.1
>>