[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191209090840.GL3365@dragon>
Date: Mon, 9 Dec 2019 17:08:42 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: Michael Walle <michael@...le.cc>, Alison Wang <alison.wang@....com>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode
+ Alison Wang
On Fri, Nov 29, 2019 at 10:09:37PM +0100, Michael Walle wrote:
> The LS1028A SoC has only unidirectional SAIs. Therefore, it doesn't make
> sense to have the RX and TX part synchronous. Even worse, the RX part
> wont work out of the box because by default it is configured as
> synchronous to the TX part. And as said before, the pinmux of the SoC
> can only be configured to route either the RX or the TX signals to the
> SAI but never both at the same time. Thus configure the asynchronous
> mode by default.
>
> Signed-off-by: Michael Walle <michael@...le.cc>
Alison, Leo,
Looks good to you?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 379913756e90..9be33426e5ce 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -637,6 +637,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 4>,
> <&edma0 1 3>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -651,6 +652,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 6>,
> <&edma0 1 5>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -665,6 +667,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 8>,
> <&edma0 1 7>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -679,6 +682,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 10>,
> <&edma0 1 9>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -693,6 +697,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 12>,
> <&edma0 1 11>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -707,6 +712,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 14>,
> <&edma0 1 13>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> --
> 2.20.1
>
Powered by blists - more mailing lists