linux-kernel - Re: [PATCH v5 2/2] iio: (bma400) add driver for the BMA400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf3f2297-dc01-b2c9-657b-933f24b15594@infradead.org>
Date:   Sun, 8 Dec 2019 18:54:44 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dan Robertson <dan@...obertson.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        devicetree@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v5 2/2] iio: (bma400) add driver for the BMA400

Hi,


On 12/8/19 5:43 PM, Dan Robertson wrote:
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index d4ef35aeb579..dc9bc646d403 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -112,6 +112,22 @@ config BMA220
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called bma220_spi.
>  
> +config BMA400
> +	tristate "Bosch BMA400 3-Axis Accelerometer Driver"
> +	select REGMAP
> +	select BMA400_I2C if (I2C)

What's with the parentheses?  I see that there are roughly 2700
"select ... if X" without parens and around 95 like
"select ... if ("  [using rough grep expressions].
The parens are unnecessary.  They are often used on complex
expressions, but certainly not on simple ones (except in iio).

> +	help
> +	  Say Y here if you want to build a driver for the Bosch BMA400
> +	  triaxial acceleration sensor.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called bma400_core and you will also get
> +	  bma400_i2c for I2C.

iff I2C is set/enabled, so could be confusing.

> +
> +config BMA400_I2C
> +	tristate
> +	depends on BMA400
> +
>  config BMC150_ACCEL
>  	tristate "Bosch BMC150 Accelerometer Driver"
>  	select IIO_BUFFER


-- 
~Randy