linux-kernel - Re: [PATCH] cpuidle: use first valid target residency as poll time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g+Jb81OOZ-na_mddP-mgeAWSKDnVsvE4ofDM2tpL8ERQ@mail.gmail.com>
Date:   Mon, 9 Dec 2019 10:39:58 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Marcelo Tosatti <mtosatti@...hat.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] cpuidle: use first valid target residency as poll time

On Fri, Dec 6, 2019 at 5:17 PM Marcelo Tosatti <mtosatti@...hat.com> wrote:
>
>
> commit 259231a045616c4101d023a8f4dcc8379af265a6 changed, by mistake,
> the target residency from the first available sleep state to the last
> available sleep state (which should be longer).
>
> This might cause excessive polling.
>
> Fixes: 259231a045616c4101d023a8f4dcc8379af265a6
>
> Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>

Applied as 5.5 material (and tagged for 5.4+-stable), thanks!

> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 0005be5ea2b4..15877b431143 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -382,6 +382,7 @@ u64 cpuidle_poll_time(struct cpuidle_driver *drv,
>                         continue;
>
>                 limit_ns = (u64)drv->states[i].target_residency_ns;
> +               break;
>         }
>
>         dev->poll_limit_ns = limit_ns;
>