linux-kernel - [PATCH 2/3] Input: elan_i2c - Do no operation for elan_smbus_sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191209111429.32315-1-dave.wang@emc.com.tw>
Date:   Mon,  9 Dec 2019 06:14:29 -0500
From:   Dave Wang <dave.wang@....com.tw>
To:     Linux-input@...r.kernel.org, Linux-kernel@...r.kernel.org,
        Dmitry.torokhov@...il.com
Cc:     phoenix@....com.tw, josh.chen@....com.tw, jingle.wu@....com.tw,
        kai.heng.feng@...onical.com, Dave Wang <dave.wang@....com.tw>
Subject: [PATCH 2/3] Input: elan_i2c - Do no operation for elan_smbus_sleep_control function

Some touchpads might get error while triggerring the sleep_control
command in SMBus interface. Do no operation for elan_smbus_sleep_control
function.

Signed-off-by: Dave Wang <dave.wang@....com.tw>
---
 drivers/input/mouse/elan_i2c_smbus.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index bcb9ec4a7a6b..9ffb1f834507 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -89,10 +89,7 @@ static int elan_smbus_set_mode(struct i2c_client *client, u8 mode)
 
 static int elan_smbus_sleep_control(struct i2c_client *client, bool sleep)
 {
-	if (sleep)
-		return i2c_smbus_write_byte(client, ETP_SMBUS_SLEEP_CMD);
-	else
-		return 0; /* XXX should we send ETP_SMBUS_ENABLE_TP here? */
+	return 0; /* A no-op */
 }
 
 static int elan_smbus_power_control(struct i2c_client *client, bool enable)
-- 
2.17.1