linux-kernel - Re: [PATCH v2 1/2] thermal: armada: fix register offsets for AXP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Dec 2019 16:31:26 +0000
From:   Zak Hays <zak.hays@...mark.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
CC:     "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] thermal: armada: fix register offsets for AXP

Hi Daniel,

>Hi Zak,
>
>what patch to pick up? V2 or V2?
I'm not sure I entirely understand your question. There are two patches:

Zachary Hays  thermal: armada: fix register offsets for AXP
Zachary Hays  thermal: armada: clear reset in armadaxp_init

Version 2 of each patch updates the commit message to add a "Signed-off-by"
and cleans up the commit message per Miquèl's earlier comments. Otherwise the
patches are the same as they were in version 1. The patch below is version 2 of that first patch.

Does that answer your question?
>
>What email is the correct one?
>
>        Zachary Hays <zhays@...mark.com>
>or
>        Zak Hays <zak.hays@...mark.com>
>
Both addresses route to the same place but "Zachary Hays <zhays@...mark.com>" is preferable. Sorry for the confusion.

>Also waiting for Miquel to ack the patch.
>
>Thanks
>
> -- Daniel
>
>
>On 05/12/2019 15:19, Zak Hays wrote:
>> As shown in its device tree, Armada XP has the control1 register at
>> 0x184d0, not 0x182d0.
>>
>> Signed-off-by: Zachary Hays <zhays@...mark.com>
>> ---
>> v2: update commit title and add "Signed-off-by"
>> ---
>>  drivers/thermal/armada_thermal.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
>> index 709a22f455e9..88363812033c 100644
>> --- a/drivers/thermal/armada_thermal.c
>> +++ b/drivers/thermal/armada_thermal.c
>> @@ -578,7 +578,7 @@ static const struct armada_thermal_data armadaxp_data = {
>>         .coef_m = 10000000ULL,
>>         .coef_div = 13825,
>>         .syscon_status_off = 0xb0,
>> -       .syscon_control1_off = 0xd0,
>> +       .syscon_control1_off = 0x2d0,
>>  };
>>
>>  static const struct armada_thermal_data armada370_data = {
>> --
>> 2.7.4
>>