linux-kernel - Re: [PATCH] arm64: dts: allwinner: Convert to new-style SPDX license identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191209165314.mostdak54qgo2r3y@gilmour.lan>
Date:   Mon, 9 Dec 2019 17:53:14 +0100
From:   Maxime Ripard <mripard@...nel.org>
To:     Clément Péron <peron.clem@...il.com>
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: allwinner: Convert to new-style SPDX license
 identifiers

On Mon, Dec 02, 2019 at 08:45:44PM +0100, Clément Péron wrote:
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > index f335f7482a73..84b7e9936300 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > @@ -1,4 +1,4 @@
> > > > > -// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > >  /*
> > > > >   * Copyright (C) 2019 Clément Péron <peron.clem@...il.com>
> > > > >   */
> > > >
> > > > And I'm not sure what this one (and the next) is?
> > >
> > > The license expressions in dual licensed files is wrong here, "OR"
> > > should be uppercase.
> > > I can move it to a separate commit if you like.
> >
>
> > Ah, right, indeed, this should be in a separate patch.
> So how many patch do you recommend here ?
>
> 1 for the or -> OR style fix.
> 1 to change to SPDX.
> and 1 to use the same // style everywhere ?

Yep :)

Maxime