linux-kernel - Re: [PATCH v1] ARM i.MX6q: make sure PHY fixup for KSZ9031 is applied only on one board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191209171508.GD9099@lunn.ch>
Date:   Mon, 9 Dec 2019 18:15:08 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        kernel@...gutronix.de, Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1] ARM i.MX6q: make sure PHY fixup for KSZ9031 is
 applied only on one board

Hi Oleksij

> This patch changes the MICREL KSZ9031 fixup, which was introduced for
> the "Data Modul eDM-QMX6" board in following patch, to be only activated
> for this specific board.

...

>  static void __init imx6q_enet_phy_init(void)
>  {
> +	/* Warning: please do not extend this fixup list. This fixups are
> +	 * applied even on boards where related PHY is not directly connected
> +	 * to the ethernet controller. For example with switch in the middle.
> +	 */
>  	if (IS_BUILTIN(CONFIG_PHYLIB)) {
>  		phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK,
>  				ksz9021rn_phy_fixup);
> -		phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
> -				ksz9031rn_phy_fixup);
> +
> +		if (of_machine_is_compatible("dmo,imx6q-edmqmx6"))
> +			phy_register_fixup_for_uid(PHY_ID_KSZ9031,
> +						   MICREL_PHY_ID_MASK,
> +						   ksz9031rn_phy_fixup);
> +
>  		phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
>  				ar8031_phy_fixup);
>  		phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,

What about the other 3 fixups? Are they not also equally broken,
applied for all boards, not specific boards?

	Andrew