linux-kernel - Re: [PATCH 0/6] device.h: split up into smaller pieces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGETcx8s4KCP=ZiYuU6oEpSrzgUyV4JeXpVKxXcWeiNiKgYKKA@mail.gmail.com>
Date:   Mon, 9 Dec 2019 11:52:50 -0800
From:   Saravana Kannan <saravanak@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH 0/6] device.h: split up into smaller pieces

On Mon, Dec 9, 2019 at 11:33 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> During the 5.4-rc merge Linus complained about the size of device.h and
> how it can be a pain to merge things into at times.  It's also become
> kind of a "kitchen sink" for anything related to drivers / devices /
> busses / classes and is the 10th largest include/linux/*.h file by size.
>
> So let's split it up into smaller pieces, moving things out by logical
> parts where it can be.

Yes please! Took a cursory look at the series (except 1/6) and it
looks okay to me. However, didn't check for copy-pastas or anything
that was left in device.h that could have been moved out. I'll try to
do the latter, later.

-Saravana

> Greg Kroah-Hartman (6):
>   drivers/base: base.h: add proper copyright and header info
>   device.h: move devtmpfs prototypes out of the file
>   device.h: move dev_printk()-like functions to dev_printk.h
>   device.h: move 'struct bus' stuff out to device/bus.h
>   device.h: move 'struct class' stuff out to device/class.h
>   device.h: move 'struct driver' stuff out to device/driver.h
>
>  drivers/base/base.h           |  19 +
>  drivers/base/bus.c            |   1 +
>  drivers/base/class.c          |   1 +
>  drivers/base/driver.c         |   1 +
>  include/linux/dev_printk.h    | 235 ++++++++
>  include/linux/device.h        | 999 +---------------------------------
>  include/linux/device/bus.h    | 288 ++++++++++
>  include/linux/device/class.h  | 266 +++++++++
>  include/linux/device/driver.h | 292 ++++++++++
>  init/main.c                   |   2 +-
>  10 files changed, 1108 insertions(+), 996 deletions(-)
>  create mode 100644 include/linux/dev_printk.h
>  create mode 100644 include/linux/device/bus.h
>  create mode 100644 include/linux/device/class.h
>  create mode 100644 include/linux/device/driver.h
>
> --
> 2.24.0
>