linux-kernel - Re: [PATCH] drm/gma500: add a missed gma_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Dec 2019 21:35:26 +0100
From:   Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/gma500: add a missed gma_power_end in error path

On Mon, Dec 9, 2019 at 9:57 AM Chuhong Yuan <hslester96@...il.com> wrote:
>
> oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Hi Chuhong, thanks for the patch.

Applied to drm-misc-next

-Patrik

> ---
>  drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> index 7390403ea1b7..582e09597500 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> @@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
>
>         if (!connector) {
>                 DRM_ERROR("Couldn't find connector when setting mode");
> +               gma_power_end(dev);
>                 return;
>         }
>
> --
> 2.24.0
>