linux-kernel - Re: [PATCH] driver core: Fix test_async_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bda264051bc86ad9674c655f3a0c91326088bcdd.camel@linux.intel.com>
Date:   Mon, 09 Dec 2019 12:59:36 -0800
From:   Alexander Duyck <alexander.h.duyck@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: Fix test_async_driver_probe if NUMA is
 disabled

On Mon, 2019-12-09 at 12:44 -0800, Guenter Roeck wrote:
> On Wed, Dec 04, 2019 at 09:18:28AM -0800, Alexander Duyck wrote:
> > > I thought the code is specifically checking devices which it previously
> > > created, which are well defined and understood test devices. After all,
> > > the check is in the test driver's probe function. Guess I really don't
> > > understand the code. Please take my patch as bug report, and submit
> > > whatever fix you think is correct.
> > 
> > Sorry I had overlooked that this is the test code.
> > 
> > I suppose it should be fine since we specify the node ID for all instances
> > where we register an asychronous test device.
> > 
> 
> That isn't exacly an endorsement. Would you mind submitting a patch
> that is acceptable for you ? I'll be more than happy to test it.
> 
> Thanks,
> Guenter

It isn't really worth the trouble.

I would have been concerned if the patch was in something other than test
code, and I hasn't paid close attention to the specific file being edited.

Your patch is more than enough to address the original issue you reported.

Thanks.

Acked-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>