linux-kernel - Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1cwoTbT3zsa-tfApwewDT1-ksHZs6_vkBYpKbgptsfjw@mail.gmail.com>
Date:   Tue, 10 Dec 2019 18:51:14 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Vitor Soares <Vitor.Soares@...opsys.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-i3c@...ts.infradead.org,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev

On Tue, Dec 10, 2019 at 4:37 PM Vitor Soares <Vitor.Soares@...opsys.com> wrote:
>
> +/* IOCTL commands */
> +#define I3C_DEV_IOC_MAGIC      0x07
> +
> +struct i3c_ioc_priv_xfer {
> +       struct i3c_priv_xfer __user *xfers;     /* pointers to i3c_priv_xfer */
> +       __u32 nxfers;                           /* number of i3c_priv_xfer */
> +};
> +
> +#define I3C_IOC_PRIV_XFER      \
> +       _IOW(I3C_DEV_IOC_MAGIC, 30, struct i3c_ioc_priv_xfer)
> +
> +#define  I3C_IOC_PRIV_XFER_MAX_MSGS    42

This is not a great data structure for UAPI, please see
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/tree/Documentation/core-api/ioctl.rst?h=compat-ioctl-endgame&id=927324b7900ee9b877691a8b237e272fabb21bf5

for some background. I'm planning to submit that documentation for
mainline integration soon.

     Arnd