linux-kernel - [PATCH] initramfs: forcing panic when kstrdup failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Dec 2019 10:48:41 +0800
From:   zhanglin <zhang.lin16@....com.cn>
To:     akpm@...ux-foundation.org
Cc:     rppt@...ux.ibm.com, steven.price@....com, david.engraf@...go.com,
        geert@...ux-m68k.org, linux-kernel@...r.kernel.org,
        xue.zhihong@....com.cn, wang.yi59@....com.cn,
        jiang.xuexin@....com.cn, zhanglin <zhang.lin16@....com.cn>
Subject: [PATCH] initramfs: forcing panic when kstrdup failed

preventing further undefined behaviour when kstrdup failed.

Signed-off-by: zhanglin <zhang.lin16@....com.cn>
---
 init/initramfs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/init/initramfs.c b/init/initramfs.c
index fca899622937..39a4fba48cc7 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -125,6 +125,8 @@ static void __init dir_add(const char *name, time64_t mtime)
 		panic("can't allocate dir_entry buffer");
 	INIT_LIST_HEAD(&de->list);
 	de->name = kstrdup(name, GFP_KERNEL);
+	if (!de->name)
+		panic("can't allocate dir_entry.name buffer");
 	de->mtime = mtime;
 	list_add(&de->list, &dir_list);
 }
@@ -340,6 +342,8 @@ static int __init do_name(void)
 				if (body_len)
 					ksys_ftruncate(wfd, body_len);
 				vcollected = kstrdup(collected, GFP_KERNEL);
+				if (!vcollected)
+					panic("can not allocate vcollected buffer.");
 				state = CopyFile;
 			}
 		}
-- 
2.17.1