linux-kernel - Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191210194113.GA10106@ubuntu-m2-xlarge-x86>
Date:   Tue, 10 Dec 2019 12:41:13 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] net: tulip: Adjust indentation in
 {dmfe,uli526x}_init_module

On Mon, Dec 09, 2019 at 08:29:20PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@...il.com>
> Date: Mon,  9 Dec 2019 14:16:23 -0700
> 
> > Clang warns:
> > 
> > ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
> > indentation; statement is not part of the previous 'if'
> > [-Wmisleading-indentation]
> >         switch (mode) {
> >         ^
> > ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
> > statement is here
> >         if (cr6set)
> >         ^
> > 1 warning generated.
> > 
> > ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
> > indentation; statement is not part of the previous 'if'
> > [-Wmisleading-indentation]
> >         switch(mode) {
> >         ^
> > ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
> > statement is here
> >         if (cr6set)
> >         ^
> > 1 warning generated.
> > 
> > This warning occurs because there is a space before the tab on these
> > lines. Remove them so that the indentation is consistent with the Linux
> > kernel coding style and clang no longer warns.
> > 
> > While we are here, adjust the default block in dmfe_init_module to have
> > a proper break between the label and assignment and add a space between
> > the switch and opening parentheses to avoid a checkpatch warning.
> > 
> > Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/795
> > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> 
> Applied, but it's really crummy that the tool gets tripped up by the
> fact that a space preceeds the TAB.  It's what the code visually looks
> like, not what exact kinds of SPACE characters were used to get there.

I agree. There is a follow up patch from the author of the warning that
claims to alieviate some of these but that is still in discussion and as
far as I understand it, it won't fix all of them so I'm just dealing
with all of them on the Linux side.

https://reviews.llvm.org/D71037

Thanks for picking them up!
Nathan