linux-kernel - Re: [PATCH] drm/amd/display: include linux/slab.h where needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cded03ab-40fe-a904-7b1f-5b3623bb7af4@amd.com>
Date:   Tue, 10 Dec 2019 15:30:21 -0500
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>
To:     Arnd Bergmann <arnd@...db.de>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     Eric Yang <Eric.Yang2@....com>, Roman Li <Roman.Li@....com>,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Michael Strauss <michael.strauss@....com>,
        dri-devel@...ts.freedesktop.org,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>
Subject: Re: [PATCH] drm/amd/display: include linux/slab.h where needed

On 2019-12-10 2:59 p.m., Arnd Bergmann wrote:
> Calling kzalloc() and related functions requires the
> linux/slab.h header to be included:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function 'dcn21_ipp_create':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:679:3: error: implicit declaration of function 'kzalloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration]
>     kzalloc(sizeof(struct dcn10_ipp), GFP_KERNEL);
> 
> A lot of other headers also miss a direct include in this file,
> but this is the only one that causes a problem for now.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

What version of the kernel are you building?

We have:

#include <linux/slab.h>

in os_types.h which gets included as part of this file:

#include <dc.h> -> #include <dc_types.h> -> #include <os_types.h>

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 906c84e6b49b..af57885bbff2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -23,6 +23,8 @@
>    *
>    */
>   
> +#include <linux/slab.h>
> +
>   #include "dm_services.h"
>   #include "dc.h"
>   
>