linux-kernel - Re: [PATCH v2] mm: cleanup some useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191210210403.GA455280@chrisdown.name>
Date:   Tue, 10 Dec 2019 21:04:03 +0000
From:   Chris Down <chris@...isdown.name>
To:     chengkaitao <pilgrimtao@...il.com>
Cc:     hannes@...xchg.org, mhocko@...nel.org, vdavydov.dev@...il.com,
        akpm@...ux-foundation.org, cgroups@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        smuchun@...il.com, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2] mm: cleanup some useless code

chengkaitao writes:
>Subject: Re: [PATCH v2] mm: cleanup some useless code

Can you please write a more descriptive commit title? Seeing this in the commit 
history tells the reader nothing, "code" could mean anything from a state 
machine to a boolean, and "cleanup" could mean anything from some complex 
refactoring to something trivial like this, and right now I have to look and 
see the individual commit. This patch is really just deduplication of effort.

Perhaps:

     mm, memcg: Don't check PageTransHuge before calling hpage_nr_pages

>It is much simpler to just use hpage_nr_pages for nr_pages and replace
>the local variable by PageTransHuge check directly

Heh, calling it "much" simpler seems a bit excessive. I mean, the code is just 
as readable in both cases, but if it's going to go in, then that's fine. Any 
merge conflict should be trivial enough to fix.

>Signed-off-by: Kaitao Cheng <pilgrimtao@...il.com>
>Acked-by: Michal Hocko <mhocko@...e.com>

I'm indifferent to this patch, but after the title change:

Acked-by: Chris Down <chris@...isdown.name>