linux-kernel - Re: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB7023CD288FCC57806F067FD9EE5B0@VI1PR04MB7023.eurprd04.prod.outlook.com>
Date:   Tue, 10 Dec 2019 21:35:05 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Anson Huang <anson.huang@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO
 regulator

On 24.10.2019 11:51, Anson Huang wrote:
> On i.MX6UL 14x14 EVK board, sensors' power are controlled
> by GPIO5_IO02, add GPIO regulator for sensors to manage
> their power.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>

For me this breaks network boot on imx6ul evk, relevant log snippet is this:

     fec 20b4000.ethernet eth0: Unable to connect to phy
     IP-Config: Failed to open eth0

Looking at schematics (SPF-28616_C2.pdf) I see that SNVS_TAMPER2 pin is 
connected to PERI_PWREN which controls VPERI_3V3 which is used across 
the board:
  * Sensors (VSENSOR_3V3)
  * Ethernet (VENET_3V3)
  * Bluetooth
  * CAN
  * Arduino header
  * Camera

Maybe there are board revision differences? As far as I can tell this 
regulator is not specific to sensors so it should be always on.

> ---
>   arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index c2a9dd5..4074570 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -30,6 +30,16 @@
>   		enable-active-high;
>   	};
>   
> +	reg_sensors: regulator-sensors {
> +		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_sensors_reg>;
> +		regulator-name = "sensors-supply";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio5 2 GPIO_ACTIVE_LOW>;
> +	};
> +
>   	reg_can_3v3: regulator-can-3v3 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "can-3v3";
> @@ -448,6 +458,12 @@
>   		>;
>   	};
>   
> +	pinctrl_sensors_reg: sensorsreggrp {
> +		fsl,pins = <
> +			MX6UL_PAD_SNVS_TAMPER2__GPIO5_IO02	0x1b0b0
> +		>;
> +	};
> +
>   	pinctrl_pwm1: pwm1grp {
>   		fsl,pins = <
>   			MX6UL_PAD_GPIO1_IO08__PWM1_OUT   0x110b0
>