linux-kernel - Re: [PATCH] ppp: Adjust indentation into ppp_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191209.203251.2060454946547270295.davem@davemloft.net>
Date:   Mon, 09 Dec 2019 20:32:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     paulus@...ba.org, linux-ppp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] ppp: Adjust indentation into ppp_async_input

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon,  9 Dec 2019 15:38:59 -0700

> Clang warns:
> 
> ../drivers/net/ppp/ppp_async.c:877:6: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
>                                 ap->rpkt = skb;
>                                 ^
> ../drivers/net/ppp/ppp_async.c:875:5: note: previous statement is here
>                                 if (!skb)
>                                 ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on this
> line. Clean up this entire block's indentation so that it is consistent
> with the Linux kernel coding style and clang no longer warns.
> 
> Fixes: 6722e78c9005 ("[PPP]: handle misaligned accesses")
> Link: https://github.com/ClangBuiltLinux/linux/issues/800
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.