linux-kernel - Re: [PATCH 01/10] extcon: arizona: Correct clean up if arizona_identify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1db1ef9-91e7-0475-8c19-86fd8102cd17@samsung.com>
Date:   Tue, 10 Dec 2019 13:47:12 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     myungjoo.ham@...sung.com, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] extcon: arizona: Correct clean up if
 arizona_identify_headphone fails

On 12/9/19 8:09 PM, Charles Keepax wrote:
> In the error path of arizona_identify_headphone, neither the clamp nor
> the PM runtime are cleaned up. Add calls to clean up both of these.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> ---
>  drivers/extcon/extcon-arizona.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index e970134c95fab..79e9a24101823 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -724,6 +724,9 @@ static void arizona_identify_headphone(struct arizona_extcon_info *info)
>  	return;
>  
>  err:
> +	arizona_extcon_hp_clamp(info, false);
> +	pm_runtime_put_autosuspend(info->dev);
> +
>  	regmap_update_bits(arizona->regmap, ARIZONA_ACCESSORY_DETECT_MODE_1,
>  			   ARIZONA_ACCDET_MODE_MASK, ARIZONA_ACCDET_MODE_MIC);
>  
> 

Applied these patches in this series. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics