linux-kernel - Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa48a214-7c12-9123-88d0-00e99359f335@suse.com>
Date:   Tue, 10 Dec 2019 06:36:18 +0100
From:   Jürgen Groß <jgross@...e.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <natechancellor@...il.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Roger Pau Monné <roger.pau@...rix.com>,
        Jens Axboe <axboe@...nel.dk>,
        Stefano Stabellini <stefano.stabellini@...citrix.com>,
        xen-devel@...ts.xenproject.org, linux-block@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

On 09.12.19 22:07, Nick Desaulniers wrote:
> On Mon, Dec 9, 2019 at 12:14 PM Nathan Chancellor
> <natechancellor@...il.com> wrote:
>>
>> Clang warns:
>>
>> ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
>> statement is not part of the previous 'if' [-Wmisleading-indentation]
>>                  nr_parts = PARTS_PER_DISK;
>>                  ^
>> ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
>>                  if (err)
>>                  ^
>>
>> This is because there is a space at the beginning of this line; remove
>> it so that the indentation is consistent according to the Linux kernel
>> coding style and clang no longer warns.
>>
>> While we are here, the previous line has some trailing whitespace; clean
>> that up as well.
>>
>> Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD")
>> Link: https://github.com/ClangBuiltLinux/linux/issues/791
>> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
>> ---
>>   drivers/block/xen-blkfront.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index a74d03913822..c02be06c5299 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1113,8 +1113,8 @@ static int xlvbd_alloc_gendisk(blkif_sector_t capacity,
> 
> While you're here, would you please also removing the single space
> before the labels in this function?

AFAIK those are intended to be there.

Having labels indented by a space makes diff not believe those are
function declarations. So a patching a function with a label won't show
the label, but the function in the diff block header.


Juergen