linux-kernel - Re: [PATCH v5 2/4] lib: devres: add a helper function for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXVGuu5ZpwA-H=1QJ4PHZeH22CG_AU71nJDYqro3pz6hQ@mail.gmail.com>
Date:   Tue, 10 Dec 2019 09:06:57 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Tuowen Zhao <ztuowen@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        acelan.kao@...onical.com, "Luis R. Rodriguez" <mcgrof@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v5 2/4] lib: devres: add a helper function for ioremap_uc

On Mon, Nov 11, 2019 at 9:45 AM Lee Jones <lee.jones@...aro.org> wrote:
> On Wed, 16 Oct 2019, Tuowen Zhao wrote:
> > Implement a resource managed strongly uncachable ioremap function.
> >
> > Cc: <stable@...r.kernel.org>
> > Tested-by: AceLan Kao <acelan.kao@...onical.com>
> > Signed-off-by: Tuowen Zhao <ztuowen@...il.com>
> > Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Acked-by: Luis Chamberlain <mcgrof@...nel.org>
> > Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  include/linux/io.h |  2 ++
> >  lib/devres.c       | 19 +++++++++++++++++++
> >  2 files changed, 21 insertions(+)
>
> Applied, thanks.

This is now commit e537654b7039aacf ("lib: devres: add a helper function
for ioremap_uc") in upstream.

Do we really need this? There is only one user of ioremap_uc(), which
Christoph is trying hard to get rid of, and now you made it mandatory.
https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds