linux-kernel - Re: [PATCH] hexagon: io: Define ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42cb2e14-a2d7-8e53-509f-da201f0624a0@roeck-us.net>
Date:   Tue, 10 Dec 2019 00:23:49 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Brian Cain <bcain@...eaurora.org>,
        "open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tuowen Zhao <ztuowen@...il.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error

On 12/10/19 12:09 AM, Geert Uytterhoeven wrote:
> On Wed, Dec 4, 2019 at 2:34 PM Guenter Roeck <linux@...ck-us.net> wrote:
>> ioremap_uc is now mandatory.
>>
>> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
>>
>> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
>> Cc: Tuowen Zhao <ztuowen@...il.com>
>> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Cc: Luis Chamberlain <mcgrof@...nel.org>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>>   arch/hexagon/include/asm/io.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
>> index 539e3efcf39c..39e5605c5d42 100644
>> --- a/arch/hexagon/include/asm/io.h
>> +++ b/arch/hexagon/include/asm/io.h
>> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>>
>>   void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
>>   #define ioremap_nocache ioremap
>> -
>> +#define ioremap_uc ioremap
>>
>>   #define __raw_writel writel
> 
> Do we really need this? There is only one user of ioremap_uc(), which
> Christoph is trying hard to get rid of, and the new devres helper that
> triggers all of this :-(
> https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
> 


One may ask why we needed a devres helper in the first place if there
is indeed just one user.

Either case, I don't really care, as long as the problem is fixed.

Guenter