linux-kernel - Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce35b6d2-7ed1-be2d-6e38-4c6e89340a40@baylibre.com>
Date:   Tue, 10 Dec 2019 09:55:50 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Jun Li <lijun.kernel@...il.com>
Cc:     Tim <elatllat@...il.com>, Felipe Balbi <balbi@...nel.org>,
        "khilman@...libre.com" <khilman@...libre.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-amlogic@...ts.infradead.org" 
        <linux-amlogic@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dongjin Kim <tobetter@...il.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for
 disabling SS instances in park mode

Hi,

On 12/11/2019 21:03, Thinh Nguyen wrote:
> Hi,
> 
> Jun Li wrote:
>> This bug exists on all current versions per information I got from Synopsys.
>> + Thinh Nguyen <thinhn@...opsys.com>.
>>
>> Li Jun
> 
> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller 
> running in host mode. This should not be set for other IPs.
> 
> This can be disabled by default based on IP, but I recommend to have a 
> property to enable this feature for devices that need this.

Thanks, so this patchset is the right way to solve this.

Felipe, would it be possible to have it merged for next release ?
Should I resend it ?

Thanks,
Neil

> 
> 
>>
>> Neil Armstrong <narmstrong@...libre.com> 于2019年11月12日周二 下午5:00写道：
>>> Hi Li,
>>>
>>> On 11/11/2019 02:58, Jun Li wrote:
>>>> Hi Neil
>>>>
>>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>>> didn't see obvious performance drop by dd tests after disable park mode for
>>>> super speed, so should we just disable it by default so no need a quirk?
>>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>>> how to handle this.
>>>
>>> Did Synopsys specified a range of affected IP version ?
>>>
>>> Neil
>>>
>>>> Li Jun
>>>>
>>>> Tim <elatllat@...il.com> 于2019年11月11日周一 上午8:42写道：
>>>>> Thanks for working on this Neil,
>>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>>>      https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@...nel.org> wrote:
>>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>>> This patch updates the documentation with the information related
>>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>>> instances in park mode.
>>>>>>>
>>>>>>> CC: Dongjin Kim <tobetter@...il.com>
>>>>>>> Cc: Jianxin Pan <jianxin.pan@...ogic.com>
>>>>>>> Reported-by: Tim <elatllat@...il.com>
>>>>>>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>>>>>>> ---
>>>>>>>   Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>>>   1 file changed, 2 insertions(+)
>>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>>
>>>>>> Acked-by: Rob Herring <robh@...nel.org>
> 
> BR,
> Thinh
>