linux-kernel - Re: [PATCH v6 8/8] misc: hisi_hikey_usb: Driver to support usb functionality of Hikey960

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191210102600.GC3698263@kroah.com>
Date:   Tue, 10 Dec 2019 11:26:00 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, Yu Chen <chenyu56@...wei.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        ShuFan Lee <shufan_lee@...htek.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Felipe Balbi <balbi@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Jun Li <lijun.kernel@...il.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Jack Pham <jackp@...eaurora.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v6 8/8] misc: hisi_hikey_usb: Driver to support usb
 functionality of Hikey960

On Thu, Nov 28, 2019 at 05:10:01AM +0000, John Stultz wrote:
> From: Yu Chen <chenyu56@...wei.com>
> 
> The HiKey960 has a fairly complex USB configuration due to it
> needing to support a USB-C port for host/device mode and multiple
> USB-A ports in host mode using a single USB controller.
> 
> See schematics here:
>   https://github.com/96boards/documentation/raw/master/consumer/hikey/hikey960/hardware-docs/HiKey960_Schematics.pdf
> 
> This driver acts as a usb-role-switch intermediary, intercepting
> the role switch notifications from the tcpm code, and passing
> them on to the dwc3 core.
> 
> In doing so, it also controls the onboard hub and power gpios in
> order to properly route the data lines between the USB-C port
> and the onboard hub to the USB-A ports.
> 
> NOTE: It was noted that controlling the TYPEC_VBUS_POWER_OFF and
> TYPEC_VBUS_POWER_ON values here is not reccomended. I'm looking
> for a way to remove that bit from the logic here, but wanted to
> still get feedback on this approach.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> CC: ShuFan Lee <shufan_lee@...htek.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Suzuki K Poulose <suzuki.poulose@....com>
> Cc: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Cc: Yu Chen <chenyu56@...wei.com>
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Jun Li <lijun.kernel@...il.com>
> Cc: Valentin Schneider <valentin.schneider@....com>
> Cc: Jack Pham <jackp@...eaurora.org>
> Cc: linux-usb@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Yu Chen <chenyu56@...wei.com>
> [jstultz: Major rework to make the driver a usb-role-switch
>           intermediary]
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> Change-Id: Icf381520abd46d083750d01f91e478321560fbf9

Checkpatch is your friend :)