linux-kernel - Re: [PATCH] ARM: dts: at91: Reenable UART TX pull-ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191210105719.GF1463890@piout.net>
Date:   Tue, 10 Dec 2019 11:57:19 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Ingo van Lil <inguin@....de>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Peter Rosin <peda@...ntia.se>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
Subject: Re: [PATCH] ARM: dts: at91: Reenable UART TX pull-ups

On 03/12/2019 15:21:47+0100, Ingo van Lil wrote:
> Pull-ups for SAM9 UART/USART TX lines were disabled in a previous
> commit. However, several chips in the SAM9 family require pull-ups to
> prevent the TX lines from falling (and causing an endless break
> condition) when the transceiver is disabled.
> 
> From the SAM9G20 datasheet, 32.5.1: "To prevent the TXD line from
> falling when the USART is disabled, the use of an internal pull up
> is mandatory.". This commit reenables the pull-ups for all chips having
> that sentence in their datasheets.
> 
> Fixes: 5e04822f7db5 ("ARM: dts: at91: fixes uart pinctrl, set pullup on rx, clear pullup on tx")
> Signed-off-by: Ingo van Lil <inguin@....de>
> Cc: Peter Rosin <peda@...ntia.se>
> ---
>  arch/arm/boot/dts/at91sam9260.dtsi | 12 ++++++------
>  arch/arm/boot/dts/at91sam9261.dtsi |  6 +++---
>  arch/arm/boot/dts/at91sam9263.dtsi |  6 +++---
>  arch/arm/boot/dts/at91sam9g45.dtsi |  8 ++++----
>  arch/arm/boot/dts/at91sam9rl.dtsi  |  8 ++++----
>  5 files changed, 20 insertions(+), 20 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com