linux-kernel - Re: [PATCH v2] media: go7007: fix a miss of snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57851e6b-4cd6-af1b-4b62-4db3b2673b8a@web.de>
Date:   Tue, 10 Dec 2019 12:48:33 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-media@...r.kernel.org
Cc:     Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: go7007: fix a miss of snd_card_free

> go7007_snd_init() misses a snd_card_free() in an error path.
> Add the missed call to fix it.

Can the tag “Reported-by” be appropriate according to a review comment
from 2017-09-19?
https://lkml.org/lkml/2017/9/19/115
https://lore.kernel.org/patchwork/comment/1026462/


> Changes in v2:
>   - Use goto to simplify the code.

Thanks for your improvement of the exception handling.

Regards,
Markus