linux-kernel - Re: [PATCH] regulator: max77650: add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MftOnQVAUjOz=UGV-S2HKPpiucQp98xYTdxgt7d8obCMg@mail.gmail.com>
Date:   Tue, 10 Dec 2019 13:51:38 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] regulator: max77650: add of_match table

wt., 10 gru 2019 o 13:12 Mark Brown <broonie@...nel.org> napisał(a):
>
> On Tue, Dec 10, 2019 at 11:07:25AM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > We need the of_match table if we want to use the compatible string in
> > the pmic's child node and get the regulator driver loaded automatically.
>
> Why would we need to use a compatible string in a child node to load the
> regulator driver, surely we can just register a platform device in the
> MFD?

The device is registered all right from MFD code, but the module won't
be loaded automatically from user-space even with the right
MODULE_ALIAS() for sub-nodes unless we define the
MODULE_DEVICE_TABLE().

Besides: the DT bindings define the compatible for sub-nodes already.
We should probably conform to that.

Bart