linux-kernel - Re: [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put() in of_get_display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1df16f96a889e870045d6198b3cd301d135003f.camel@decadent.org.uk>
Date:   Tue, 10 Dec 2019 15:31:49 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Doug Anderson <dianders@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "# 4.0+" <stable@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Denis Kirjanov <kda@...ux-powerpc.org>,
        David Airlie <airlied@...ux.ie>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Russell King <linux@...linux.org.uk>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put()
 in of_get_display_timing()

On Mon, 2019-12-09 at 13:19 -0800, Doug Anderson wrote:
> Hi,
> 
> On Sun, Dec 8, 2019 at 5:54 AM Ben Hutchings <ben@...adent.org.uk> wrote:
> > 3.16.79-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Douglas Anderson <dianders@...omium.org>
> > 
> > commit 4faba50edbcc1df467f8f308893edc3fdd95536e upstream.
> > 
> > =46romcode inspection it can be seen that of_get_display_timing() is
> > lacking an of_node_put().  Add it.
> 
> I don't object, but I am curious why "From code" got turned into
> "=46romcode" in the commit message.

I'm not sure why this happened, but it has happened in the process of
generating the review mail.  The patch file I'm actually going to apply
is not affected.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed
                                                    - Carolyn Scheppner



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)