| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Dec 2019 17:34:37 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Akinobu Mita <akinobu.mita@...il.com>
Cc: Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
linux-hwmon@...r.kernel.org, Linux PM <linux-pm@...r.kernel.org>,
"open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Sujith Thomas <sujith.thomas@...el.com>,
Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Zhang Rui <rui.zhang@...el.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amit.kucheria@...durent.com>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
Christoph Hellwig <hch@....de>,
Sagi Grimberg <sagi@...mberg.me>,
Kalle Valo <kvalo@...eaurora.org>,
Stanislaw Gruszka <sgruszka@...hat.com>,
Johannes Berg <johannes.berg@...el.com>,
Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
Luca Coelho <luciano.coelho@...el.com>,
Intel Linux Wireless <linuxwifi@...el.com>,
Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH v3 00/12] add header file for kelvin to/from Celsius
conversion helpers
On Wed, Dec 11, 2019 at 4:38 PM Akinobu Mita <akinobu.mita@...il.com> wrote:
>
> There are several helper macros to convert kelvin to/from Celsius in
> <linux/thermal.h> for thermal drivers. These are useful for any other
> drivers or subsystems, but it's odd to include <linux/thermal.h> just for
> the helpers.
>
> This adds a new <linux/units.h> that provides the equivalent inline
> functions for any drivers or subsystems, and switches all the users of
> conversion helpers in <linux/thermal.h> to use <linux/units.h>
> helpers.
>
Thank you for an update.
For non-commented patches
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> * v3
> - rename new header name from <linux/temperature.h> to <linux/units.h>
> - add milli_kelvin_to_millicelsius() and millicelsius_to_milli_kelvin() and
> use them for implementing other helpers
> - add MILLIDEGREE_PER_DEGREE and MILLIDEGREE_PER_DECIDEGREE and replace
> the hardcoded constants
> - add kelvin_to_celsius() and celsius_to_kelvin() in <linux/units.h>
> - add Reviewed-by tags
> - switch iwlegacy driver to use <linux/units.h> helpers
> - switch iwlwifi driver to use <linux/units.h> helpers
> - remove unused TO_MCELSIUS macro in armada thermal driver
> - switch qcom-vadc-common module to use <linux/units.h> helpers
>
> * v2
> - add deci_kelvin_to_millicelsius_with_offset() in linux/temperature.h
> - stop including linux/temperature.h from linux/thermal.h
> - include <linux/temperature.h> explicitly from thermal drivers
> - fix s/temprature/temperature/ typo in commit log
> - use deci_kelvin_to_millicelsius_with_offset() in ACPI thermal zone driver
> - don't mix up another fix (format string for cellsius value)
> - add Acked-by and Reviewed-by tags
>
> Akinobu Mita (12):
> add helpers for kelvin to/from Celsius conversion
> ACPI: thermal: switch to use <linux/units.h> helpers
> platform/x86: asus-wmi: switch to use <linux/units.h> helpers
> platform/x86: intel_menlow: switch to use <linux/units.h> helpers
> thermal: int340x: switch to use <linux/units.h> helpers
> thermal: intel_pch: switch to use <linux/units.h> helpers
> nvme: hwmon: switch to use <linux/units.h> helpers
> thermal: remove kelvin to/from Celsius conversion helpers from
> <linux/thermal.h>
> wireless: iwlegacy: use <linux/units.h> helpers
> wireless: iwlwifi: use <linux/units.h> helpers
> thermal: armada: remove unused TO_MCELSIUS macro
> iio: adc: qcom-vadc-common: use <linux/units.h> helpers
>
> drivers/acpi/thermal.c | 36 +++++-----
> drivers/iio/adc/qcom-vadc-common.c | 6 +-
> drivers/iio/adc/qcom-vadc-common.h | 1 -
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +-
> drivers/net/wireless/intel/iwlegacy/4965.c | 11 +--
> drivers/net/wireless/intel/iwlegacy/common.h | 3 -
> drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 5 --
> drivers/net/wireless/intel/iwlwifi/dvm/devices.c | 6 +-
> drivers/nvme/host/hwmon.c | 13 ++--
> drivers/platform/x86/asus-wmi.c | 7 +-
> drivers/platform/x86/intel_menlow.c | 9 ++-
> drivers/thermal/armada_thermal.c | 2 -
> .../intel/int340x_thermal/int340x_thermal_zone.c | 7 +-
> drivers/thermal/intel/intel_pch_thermal.c | 3 +-
> include/linux/thermal.h | 11 ---
> include/linux/units.h | 84 ++++++++++++++++++++++
> 16 files changed, 139 insertions(+), 68 deletions(-)
> create mode 100644 include/linux/units.h
>
> Cc: Sujith Thomas <sujith.thomas@...el.com>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andy Shevchenko <andy@...radead.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Amit Kucheria <amit.kucheria@...durent.com>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Keith Busch <kbusch@...nel.org>
> Cc: Jens Axboe <axboe@...com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Stanislaw Gruszka <sgruszka@...hat.com>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> Cc: Luca Coelho <luciano.coelho@...el.com>
> Cc: Intel Linux Wireless <linuxwifi@...el.com>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists