linux-kernel - Re: [PATCH 0/2] PM: Add a switch for disabling/enabling sync() before suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f94b4603-f438-b516-af53-c919f392ae3c@freesources.org>
Date:   Wed, 11 Dec 2019 16:59:29 +0100
From:   Jonas Meurer <jonas@...esources.org>
To:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Tim Dittler <tim.dittler@...temli.org>,
        Yannik Sembritzki <yannik@...britzki.me>
Subject: Re: [PATCH 0/2] PM: Add a switch for disabling/enabling sync() before
 suspend

Hello,

Jonas Meurer:
> Hello,
> 
> Introduce a new run-time sysfs switch to disable/enable sync() before
> system suspend. This is useful to avoid races and deadlocks if block
> devices have been suspended before, e.g. by 'cryptsetup luksSuspend'.
> 
> The second patch changes the behaviour of build-time switch
> 'CONFIG_SUSPEND_SKIP_SYNC' accordingly, using the build-time switch value
> as default for our new run-time switch '/sys/power/sync_on_suspend'.
> 
> Jonas Meurer (2):
>   PM: Add a switch for disabling/enabling sync() before suspend
>   PM: CONFIG_SUSPEND_SKIP_SYNC sets default for '/sys/power/sync_on_suspend'
> 
>  Documentation/ABI/testing/sysfs-power | 15 +++++++++++++++
>  include/linux/suspend.h               |  2 ++
>  kernel/power/Kconfig                  |  5 ++++-
>  kernel/power/main.c                   | 33 +++++++++++++++++++++++++++++++++
>  kernel/power/suspend.c                |  2 +-
>  5 files changed, 55 insertions(+), 2 deletions(-)

Any chance to get a review/comment on this patch? What's the next
logical steps to get it merged?

Cheers
 jonas