linux-kernel - Re: [PATCH v2 09/12] ARM: dts: aspeed: ast2600: Add XDMA Engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5086ee4b-bddb-40c1-9841-005b233f837b@www.fastmail.com>
Date:   Wed, 11 Dec 2019 14:18:45 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Eddie James" <eajames@...ux.ibm.com>, linux-kernel@...r.kernel.org
Cc:     devicetree@...r.kernel.org, "Jason Cooper" <jason@...edaemon.net>,
        linux-aspeed@...ts.ozlabs.org, "Marc Zyngier" <maz@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>, tglx@...utronix.de,
        mark.rutland@....com, "Joel Stanley" <joel@....id.au>
Subject: Re: [PATCH v2 09/12] ARM: dts: aspeed: ast2600: Add XDMA Engine



On Fri, 6 Dec 2019, at 03:45, Eddie James wrote:
> Add a node for the XDMA engine with all the necessary information. Also
> add a simple syscon node for the SDRAM memory controller.
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> ---
> Changes since v1:
>  - Add a syscon SDRAM controller
>  - Add various properties to XDMA node
> 
>  arch/arm/boot/dts/aspeed-g6.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index ead336e..514d685 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -3,6 +3,7 @@
>  
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/clock/ast2600-clock.h>
> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h>
>  
>  / {
>  	model = "Aspeed BMC";
> @@ -265,6 +266,11 @@
>  			status = "disabled";
>  		};
>  
> +		sdmc: sdram@...e0000 {
> +			compatible = "syscon";
> +			reg = <0x1e6e0000 0xb8>;
> +		};
> +

Hopefully we can drop this. We also need to figure out how whatever the solution is interacts
with the EDAC driver.

>  		apb {
>  			compatible = "simple-bus";
>  			#address-cells = <1>;
> @@ -311,6 +317,19 @@
>  				quality = <100>;
>  			};
>  
> +			xdma: xdma@...e7000 {
> +				compatible = "aspeed,ast2600-xdma";
> +				reg = <0x1e6e7000 0x100>;
> +				clocks = <&syscon ASPEED_CLK_GATE_BCLK>;
> +				resets = <&syscon ASPEED_RESET_DEV_XDMA>;
> +				interrupts-extended = <&gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> +						      <&scu_ic0 ASPEED_AST2600_SCU_IC0_PCIE_PERST_LO_TO_HI>;
> +				pcie-device = "bmc";
> +				scu = <&syscon>;
> +				sdmc = <&sdmc>;

sdmc property should go away also.

> +				status = "disabled";
> +			};
> +
>  			gpio0: gpio@...80000 {
>  				#gpio-cells = <2>;
>  				gpio-controller;
> -- 
> 1.8.3.1
> 
>