linux-kernel - Re: [PATCH] tracing: Avoid memory leak in process_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191211100811.17dc5fbe@gandalf.local.home>
Date:   Wed, 11 Dec 2019 10:08:11 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
Cc:     takafumi.kubota1012@...ab.ics.keio.ac.jp,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Avoid memory leak in process_system_preds()

On Wed, 11 Dec 2019 09:12:58 +0000
Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp> wrote:

> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -1662,7 +1662,7 @@ static int process_system_preds(struct trace_subsystem_dir *dir,
>  	parse_error(pe, FILT_ERR_BAD_SUBSYS_FILTER, 0);
>  	return -EINVAL;
>   fail_mem:
> -	kfree(filter);
> +	__free_filter(filter);
>  	/* If any call succeeded, we still need to sync */
>  	if (!fail)
>  		tracepoint_synchronize_unregister();

Applied. Thanks Keita!

-- Steve