linux-kernel - RE: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB7PR02MB3979B35C4DED689057F60192BB5A0@DB7PR02MB3979.eurprd02.prod.outlook.com>
Date:   Wed, 11 Dec 2019 16:16:21 +0000
From:   Mircea CIRJALIU - MELIU <mcirjaliu@...defender.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jerome Glisse <jglisse@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "aarcange@...hat.com" <aarcange@...hat.com>
Subject: RE: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range
 invalidation

> On Wed, Dec 11, 2019 at 09:29:21AM +0000, Mircea CIRJALIU - MELIU wrote:
> > MMU notifier client may need the VMA for extra info.
> > This change is needed by the remote mapping feature that inspects anon
> > VMAs with huge mappings.
> 
> The change itself is okay, but commit message should be better.
> 
> Do we have any user of mmu notifiers in current kernel that affected by the
> missing vma here?

No. This patch is a small part of a series of commits for the remote mapping feature.
The kernel can do well without it.

> 
> And subject starting with 'also' looks wrong to me.
> 
> --
>  Kirill A. Shutemov

Mircea