linux-kernel - Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211171808.GB1530@gerhold.net>
Date:   Wed, 11 Dec 2019 18:18:08 +0100
From:   Stephan Gerhold <stephan@...hold.net>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo

On Wed, Dec 11, 2019 at 12:46:39PM +0100, Linus Walleij wrote:
> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> has a typo error renaming "ab8500-clk" to "abx500-clk"
> with the result att ALSA SoC audio broke as the clock
> driver was not probing anymore. Fixed it up.
> 
> Cc: Stephan Gerhold <stephan@...hold.net>
> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

FWIW:
Reviewed-by: Stephan Gerhold <stephan@...hold.net>

> ---
>  drivers/mfd/ab8500-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index bafc729fc434..3c6fda68e6bc 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -631,8 +631,8 @@ static const struct mfd_cell ab8500_devs[] = {
>  		    NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),
>  	OF_MFD_CELL("ab8500-regulator",
>  		    NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),
> -	OF_MFD_CELL("abx500-clk",
> -		    NULL, NULL, 0, 0, "stericsson,abx500-clk"),
> +	OF_MFD_CELL("ab8500-clk",
> +		    NULL, NULL, 0, 0, "stericsson,ab8500-clk"),
>  	OF_MFD_CELL("ab8500-gpadc",
>  		    NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),
>  	OF_MFD_CELL("ab8500-rtc",
> -- 
> 2.23.0
>