linux-kernel - Re: [PATCH 1/2] kselftest/runner: Print new line in print of timeout log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbbe2517-06bc-36c4-8762-a2cd28fa1e4a@kernel.org>
Date:   Wed, 11 Dec 2019 10:19:50 -0700
From:   shuah <shuah@...nel.org>
To:     Kees Cook <keescook@...omium.org>,
        SeongJae Park <sjpark@...zon.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        sj38.park@...il.com, SeongJae Park <sjpark@...zon.de>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH 1/2] kselftest/runner: Print new line in print of timeout
 log

On 12/7/19 11:47 AM, Kees Cook wrote:
> On Mon, Dec 02, 2019 at 12:42:20PM +0100, SeongJae Park wrote:
>> From: SeongJae Park <sjpark@...zon.de>
>>
>> If a timeout failure occurs, kselftest kills the test process and prints
>> the timeout log.  If the test process has killed while printing a log
>> that ends with new line, the timeout log can be printed in middle of the
>> test process output so that it can be seems like a comment, as below:
>>
>>      # test_process_log	not ok 3 selftests: timers: nsleep-lat # TIMEOUT
>>
>> This commit avoids such problem by printing one more line before the
>> TIMEOUT failure log.
>>
>> Signed-off-by: SeongJae Park <sjpark@...zon.de>
> 
> Acked-by: Kees Cook <keescook@...omium.org>
> 
> Cool, yeah, this looks fine to me. Nice idea!
> 
> -Kees
> 
>> ---
>>   tools/testing/selftests/kselftest/runner.sh | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
>> index 84de7bc74f2c..a8d20cbb711c 100644
>> --- a/tools/testing/selftests/kselftest/runner.sh
>> +++ b/tools/testing/selftests/kselftest/runner.sh
>> @@ -79,6 +79,7 @@ run_one()
>>   		if [ $rc -eq $skip_rc ]; then	\
>>   			echo "not ok $test_num $TEST_HDR_MSG # SKIP"
>>   		elif [ $rc -eq $timeout_rc ]; then \
>> +			echo "#"
>>   			echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
>>   		else
>>   			echo "not ok $test_num $TEST_HDR_MSG # exit=$rc"
>> -- 
>> 2.17.1
>>
> 

Thanks. Applying to fixes for the next 5.5-rc

-- Shuah