linux-kernel - Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8994c4a9-4cf3-5d20-0a89-f1501075d1a7@gmail.com>
Date:   Wed, 11 Dec 2019 19:06:35 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Michael Kao <michael.kao@...iatek.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, hsinyi@...omium.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Dawei Chien <dawei.chien@...iatek.com>, mn.tsou@...iatek.com
Subject: Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node.



On 11/12/2019 09:13, Michael Kao wrote:
> On Thu, 2019-12-05 at 17:00 +0100, Daniel Lezcano wrote:
>> Hi Michael,
>>
>>
>> On 22/11/2019 10:06, michael.kao@...iatek.com wrote:
>>> From: "michael.kao" <michael.kao@...iatek.com>
>>>
>>> This device node is for calculating dynamic power in mW.
>>> Since mt8173 has two clusters, there are two dynamic power
>>> coefficient as well.
>>
>> Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2.
> 
> Hi Daniel,
> 
> I have confirmed again with our IC designer.
> The dynamic power coefficients are these value is right.
> Designer comment that it is result from different IC implement.

Applied to v5.5-next/dts64

Thanks!
Matthias

>>
>>> Signed-off-by: Dawei Chien <dawei.chien@...iatek.com>
>>> Signed-off-by: Michael.Kao <michael.kao@...iatek.com>
>>>
>>> ---
>>>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 15f1842f6df3..b03ca5a71338 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -157,6 +157,7 @@
>>>  			enable-method = "psci";
>>>  			cpu-idle-states = <&CPU_SLEEP_0>;
>>>  			#cooling-cells = <2>;
>>> +			dynamic-power-coefficient = <263>;
>>>  			clocks = <&infracfg CLK_INFRA_CA53SEL>,
>>>  				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>  			clock-names = "cpu", "intermediate";
>>> @@ -170,6 +171,7 @@
>>>  			enable-method = "psci";
>>>  			cpu-idle-states = <&CPU_SLEEP_0>;
>>>  			#cooling-cells = <2>;
>>> +			dynamic-power-coefficient = <263>;
>>>  			clocks = <&infracfg CLK_INFRA_CA53SEL>,
>>>  				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>  			clock-names = "cpu", "intermediate";
>>> @@ -183,6 +185,7 @@
>>>  			enable-method = "psci";
>>>  			cpu-idle-states = <&CPU_SLEEP_0>;
>>>  			#cooling-cells = <2>;
>>> +			dynamic-power-coefficient = <530>;
>>>  			clocks = <&infracfg CLK_INFRA_CA72SEL>,
>>>  				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>  			clock-names = "cpu", "intermediate";
>>> @@ -196,6 +199,7 @@
>>>  			enable-method = "psci";
>>>  			cpu-idle-states = <&CPU_SLEEP_0>;
>>>  			#cooling-cells = <2>;
>>> +			dynamic-power-coefficient = <530>;
>>>  			clocks = <&infracfg CLK_INFRA_CA72SEL>,
>>>  				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>  			clock-names = "cpu", "intermediate";
>>>
>>
>>
>