linux-kernel - Re: [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0101016ef33fd5d9-8367442a-f863-4f64-9787-f49c716156e5-000000@us-west-2.amazonses.com>
Date:   Wed, 11 Dec 2019 04:37:57 +0000
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Douglas Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>
Cc:     mka@...omium.org, Roja Rani Yarubandi <rojay@...eaurora.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about
 external pullup



On 12/11/2019 6:05 AM, Douglas Anderson wrote:
> Make i2c7 symmetric with the other i2c busses and comment that we have
> no internal pull because there is an external one.
> 
> Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---

Reviewed-by: Rajendra Nayak <rnayak@...eaurora.org>

> 
>   arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 5eab3a282eba..05d30a56eca9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -311,6 +311,8 @@ &qup_i2c7_default {
>   	pinconf {
>   		pins = "gpio6", "gpio7";
>   		drive-strength = <2>;
> +
> +		/* Has external pullup */
>   		bias-disable;
>   	};
>   };
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation