linux-kernel - Re: [PATCH 1/4] gpio: add gpiod_toggle_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ0mk2dWBnWh+mRmBy2t-ALONtvv23Hr-2o8LD8CPYtgg@mail.gmail.com>
Date:   Wed, 11 Dec 2019 01:39:54 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>
Subject: Re: [PATCH 1/4] gpio: add gpiod_toggle_active_low()

On Mon, Dec 9, 2019 at 10:09 PM Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:

> Add possibility to toggle active-low flag of a gpio descriptor. This is
> useful for compatibility code, where defaults are inverted vs DT gpio
> flags or the active-low flag is taken from elsewhere.
>
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Proliferating APIs isn't good but I think this is the lesser evil
given the mess there is in the MMC subsystem for this stuff.

Maybe I can make a second attempt to move all polarity
toggling back to gpiolib-of.c and remove the API after this
has landed, hehe ;)

Yours,
Linus Walleij