linux-kernel - Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211190235.GA17854@lst.de>
Date:   Wed, 11 Dec 2019 20:02:35 +0100
From:   Christoph Hellwig <hch@....de>
To:     Robin Murphy <robin.murphy@....com>
Cc:     joro@...tes.org, hch@....de, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, stephan@...hold.net,
        natechancellor@...il.com, nsaenzjulienne@...e.de, arnd@...db.de
Subject: Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks

On Wed, Dec 11, 2019 at 06:33:26PM +0000, Robin Murphy wrote:
> Since iommu_dma_alloc_iova() combines incoming masks with the u64 bus
> limit, it makes more sense to pass them around in their native u64
> rather than converting to dma_addr_t early. Do that, and resolve the
> remaining type discrepancy against the domain geometry with a cheeky
> cast to keep things simple.
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>

Looks good to me:

Reviewed-by: Christoph Hellwig <hch@....de>

Joerg, let me know if you want to pick this up through the iommu tree as
it touches the iommu code, or through the dma-mapping tree that
introduced the warning.