linux-kernel - Re: [PATCH 2/2] perf/x86/intel/bts: Fix the use of page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h827cr96.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Wed, 11 Dec 2019 08:26:13 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH 2/2] perf/x86/intel/bts: Fix the use of page_private()

Peter Zijlstra <peterz@...radead.org> writes:

>>  static size_t buf_size(struct page *page)
>>  {
>> -	return 1 << (PAGE_SHIFT + page_private(page));
>> +	return 1 << (PAGE_SHIFT + buf_nr_pages(page));
>
> Hurmph, shouldn't that be:
>
> 	return buf_nr_pages(page) * PAGE_SIZE;
>
> ?

True, that one's broken.