linux-kernel - RE: [PATCH v6 05/13] exfat: add file operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002a01d5afbe$6e64e250$4b2ea6f0$@samsung.com>
Date:   Wed, 11 Dec 2019 10:00:50 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Vyacheslav Dubeyko'" <slava@...eyko.com>
Cc:     <gregkh@...uxfoundation.org>, <valdis.kletnieks@...edu>,
        <hch@....de>, <sj1557.seo@...sung.com>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v6 05/13] exfat: add file operations


> > +	/* Of the r and x bits, all (subject to umask) must be
> > present.*/
> > +	if ((perm & 0555) != (i_mode & 0555))
I modified it due to warnning alarm from checkpatch.pl.
Other octal permissions are same reason.
WARNING: Symbolic permissions 'S_IRUGO | S_IXUGO' are not preferred. Consider using octal permissions '0555'.
+       if ((perm & (S_IRUGO | S_IXUGO)) != (i_mode & (S_IRUGO | S_IXUGO)))

> > +	/* update the directory entry */
> > +	if (!evict) {
> > +		es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry,
> > +				ES_ALL_ENTRIES, &ep);
> > +		if (!es)
> > +			return -EIO;
> > +		ep2 = ep + 1;
> 
> The ep2 could point out on the garbage here. Maybe, it makes sense to
> add some check here?
Could you please elaborate more? How could ep2 be the garbage?
I want you to check exfat_get_dentry_set().

Thanks for your review!