linux-kernel - Re: [PATCH] gpio: xgs-iproc: remove __exit annotation for iproc_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJVuN5vqA1j0ddpctJQJJMPu1EnakduO2rJnBo3Ao==Enw@mail.gmail.com>
Date:   Wed, 11 Dec 2019 10:14:18 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "arnd@...db.de" <arnd@...db.de>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "scott.branden@...adcom.com" <scott.branden@...adcom.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] gpio: xgs-iproc: remove __exit annotation for iproc_gpio_remove

wt., 10 gru 2019 o 21:24 Chris Packham
<Chris.Packham@...iedtelesis.co.nz> napisał(a):
>
> On Tue, 2019-12-10 at 20:54 +0100, Arnd Bergmann wrote:
> > When built into the kernel, the driver causes a link problem:
> >
> > `iproc_gpio_remove' referenced in section `.data' of drivers/gpio/gpio-xgs-iproc.o: defined in discarded section `.exit.text' of drivers/gpio/gpio-xgs-iproc.o
> >
> > Remove the incorrect annotation.
> >
> > Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>
> What's the current best practice w.r.t.__init and __exit? I seem to
> have messed this up on multiple fronts.
>

Applied for fixes.

Bartosz