linux-kernel - Re: [PATCHv1 0/3] Enable crypto module on Amlogic GXBB SoC platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2b54743-87da-091e-8d62-288ee29a54b0@baylibre.com>
Date:   Wed, 11 Dec 2019 10:32:01 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Anand Moon <linux.amoon@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Corentin Labbe <clabbe@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "David S . Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCHv1 0/3] Enable crypto module on Amlogic GXBB SoC platform

On 11/12/2019 10:27, Herbert Xu wrote:
> On Wed, Dec 11, 2019 at 09:53:56AM +0100, Neil Armstrong wrote:
>>
>> On 11/12/2019 09:41, Anand Moon wrote:
>>> [sudo] password for alarm:
>>> [  903.867059] tcrypt:
>>> [  903.867059] testing speed of async ecb(aes) (ecb(aes-arm64)) encryption
>>
>> Wow, I'm surprised it works on GXBB, Amlogic completely removed HW crypto for GXBB in all their
>> vendor BSPs, in Linux, U-Boot and ATF chain.
>>
>> Could you run more tests to be sure it's really functional ?
> 
> Well as you can see from the tcrypt output, it's actually using
> aes-arm64 which is certainly not the amlogic driver.  Presumably
> the amlogic driver failed to load/register.

Nice catch... thanks Herbert.

Neil

> 
> Cheers,
>