linux-kernel - Re: [PATCH] crypto: chacha - fix warning message in header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191211094553.z7pemzak6gycfd26@gondor.apana.org.au>
Date:   Wed, 11 Dec 2019 17:45:53 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: chacha - fix warning message in header file

On Thu, Dec 05, 2019 at 08:58:36PM -0500, Valdis Klētnieks wrote:
> Building with W=1 causes a warning:
> 
>   CC [M]  arch/x86/crypto/chacha_glue.o
> In file included from arch/x86/crypto/chacha_glue.c:10:
> ./include/crypto/internal/chacha.h:37:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
>    37 | static int inline chacha12_setkey(struct crypto_skcipher *tfm, const u8 *key,
>       | ^~~~~~
>  
> Straighten out the order to match the rest of the header file.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt